This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Import simple telemetry implementation without native_deps and language interface implementation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge interface implementation
|
🔥 |
|
I can't accept it while it's still in draft though |
pawelchcki
force-pushed
the
pawel/merge_dd_telemetry
branch
from
663c4c3
to
df0be1f
Compare
Cargo.toml
Outdated
| @@ -7,6 +7,7 @@ members = [ | |||
| "ddprof-exporter", | |||
| "ddprof-ffi", | |||
| "ddprof-profiles", | |||
| "telemetry", | |||
There was a problem hiding this comment.
BTW, if the crate is ever pushed, this would be its exact name. I think it should be ddtelemetry or dd-telemetry or something -- not sure on the exact naming scheme. I was thinking about collapsing all the ddprof crates into just ddprof or dd-prof.
Or maybe we should spell them out datadog-*, but dunno if we can get control of the datadog crate. Definitely not going to be able to get the dd crate ^_^
There was a problem hiding this comment.
following dd-trace-* example I think we could standardise on dd- name for rust crates. BTW I just tested, and we can easily add libdatadog-owners as owners of a crate.
paullegranddc
approved these changes
Apr 13, 2022
pawelchcki
force-pushed
the
pawel/merge_dd_telemetry
branch
from
4392fce
to
0e9bbf8
Compare
…/libddprof into pawel/merge_dd_telemetry
pawelchcki
force-pushed
the
pawel/merge_dd_telemetry
branch
from
0c82125
to
ec8bd95
Compare
pawelchcki
force-pushed
the
pawel/merge_dd_telemetry
branch
from
ec8bd95
to
a6cfe24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial merge of only telemetry related code from the telemetry shared library.
Python interface and additional cargo crates are planned to be merged later.